Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates several references and minor behaviors, including changes in test outputs, API calls, package versions, and CI workflow improvements.
- Updated expected newline count in a text rendering test
- Changed API call syntax for image bounds in FillProcessor and FillPathProcessor
- Upgraded package reference versions and improved the Ubuntu CI workflow step
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ImageSharp.Drawing.Tests/Drawing/Text/DrawTextOnImageTests.cs | Updated the expected newline repetition count in the text rendering test. |
| src/ImageSharp.Drawing/Processing/Processors/Drawing/FillProcessor{TPixel}.cs | Modified API call syntax from a method call to a property for retrieving image bounds. |
| src/ImageSharp.Drawing/Processing/Processors/Drawing/FillPathProcessor{TPixel}.cs | Modified API call syntax from a method call to a property for retrieving image bounds. |
| src/ImageSharp.Drawing/ImageSharp.Drawing.csproj | Updated package versions for SixLabors.Fonts and SixLabors.ImageSharp. |
| .github/workflows/build-and-test.yml | Updated Ubuntu package installation step via improved condition and added apt-get update. |
Comments suppressed due to low confidence (1)
tests/ImageSharp.Drawing.Tests/Drawing/Text/DrawTextOnImageTests.cs:272
- The increase in newline repetitions from 31 to 61 should be confirmed against the intended text output. Ensure that all related test expectations and baselines are updated to reflect this change.
string newLines = Repeat("\r\n", 61);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description